✨ Make individual readiness and liveness checks accessible #1100
Conversation
When a named readiness/liveness check is registered it should be available under /readyz/<name>.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
/assign @joelanford |
There was a problem hiding this comment.
/lgtm
nice catch! So the main idea behind this is that mux.Handler when using pattern with trailing slash also handles subtrees, right? Was not apparent to me at first sight 👍
Also we allow the readiness endpoint to be overwritten so if one provides one without trailing slash, it won't handle subtrees again, right?
k8s-ci-robot
added
the
lgtm
|
@alenkacz That's right. Also, someone could add an endpoint without trailing slash that would override the root path. It's a bit funky but I think this is right default behaviour. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, jimmidyson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
By kubernetes-sigs#1100, subpaths of `/healthz/` can be handled. However, this change introduced the redirection from `/healthz` to `/healthz/` with 301 (Moved Permanently) when accessing `/healthz` endpoint. (Accessing `/healthz/` works fine without the redirect.) This is unnecessary overhead in the health checking. So, this commit enable to access `/healthz` without the redirect with keeping that subpaths of `/healthz/` are accessible.
By kubernetes-sigs#1100, subpaths of `/healthz/` can be handled. However, this change introduced the redirection from `/healthz` to `/healthz/` with 301 (Moved Permanently) when accessing `/healthz` endpoint. (Accessing `/healthz/` works fine without the redirect.) This is unnecessary overhead in the health checking. So, this commit enable to access `/healthz` without the redirect with keeping that subpaths of `/healthz/` are accessible.
When a named readiness/liveness check is registered it should be available under /readyz/.
This PR enables this by adding a trailing slash to the default readyz and healthz endpoints, configuring
the server to handle existing path (
/readyz) and subpaths (/readyz/my-check).