Skip to content

Revert "Revert "Updating to k8s 1.11."" #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

n3wscott
Copy link

Reverts #110

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: n3wscott
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: droot

If they are not already assigned, you can assign the PR to them by writing /assign @droot in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 14, 2018
@DirectXMan12
Copy link
Contributor

/hold

the maintainers need to have an extended discussion to figure out how we want to handle versioning. As it stands right now, any change in kubernetes dependencies is functionally equivalent to a breaking change (due to kubebuilder projects' pinned dependencies), and we'll need to figure out how we want to deal with changes to dependencies vs changes to interfaces...

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2018
@grantr
Copy link
Contributor

grantr commented Aug 15, 2018

FWIW knative/eventing is working around this for now with a fork.

@dims
Copy link
Member

dims commented Aug 24, 2018

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from dims August 24, 2018 12:53
@droot
Copy link
Contributor

droot commented Aug 29, 2018

closing this PR because of too many conflicts causing rebase hell. Created fresh PR #125

@droot droot closed this Aug 29, 2018
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
set version field correctly during KB compilation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants