cleaned up the Dep manifest for k8s 1.10 #114
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
size/L
droot
force-pushed
the
k8s-1.10-with-clean-deps
branch
from
116c1a8 to
beafcf9
Compare
droot
force-pushed
the
k8s-1.10-with-clean-deps
branch
from
beafcf9 to
60966b1
Compare
k8s-ci-robot
added
size/XXL
|
/lgtm |
k8s-ci-robot
added
the
lgtm
| name = "github.com/go-logr/logr" | ||
| revision = "9fb12b3b21c5415d16ac18dc5cd42c1cfdd40c4e" | ||
|
|
||
| [[constraint]] |
There was a problem hiding this comment.
any uses of glog are a mistake, and we should fix them (and probably have a lint).
There was a problem hiding this comment.
@DirectXMan12 Why you think we should stay away from glog?
There was a problem hiding this comment.
The direct reason is that we decided to use structured logging with logr for this library.
We decided to go with that because we've been wanting to experiment with moving away from glog for a while. It has a number of deficiencies (confusing flags, bad defaults, etc), it's not pluggable for people using other logging mechanisms, and it's unstructured. Structured logging lets us capture useful information in a much-easier-to-parse way.
…-deps cleaned up the Dep manifest for k8s 1.10
Control -x in test.sh with TRACE
Updated the Gopkg.toml file to pin only the k8s deps.