Skip to content

move cert pkg to internal #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Aug 22, 2018

No description provided.

@mengqiy mengqiy requested a review from droot August 22, 2018 21:06
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 22, 2018
@mengqiy mengqiy force-pushed the move_pkg_to_internal branch from 7f2a188 to 788468e Compare August 22, 2018 21:34
@mengqiy
Copy link
Member Author

mengqiy commented Aug 23, 2018

Applying labels based on discussion yesterday with @droot. Merging this PR to unblock other works

@mengqiy mengqiy added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 23, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ab29e82 into kubernetes-sigs:admissionwebhook Aug 23, 2018
@mengqiy mengqiy deleted the move_pkg_to_internal branch August 23, 2018 16:56
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
Make it possible to skip fetch and untar of tools in test script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants