glog elimination round 2 #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The event recorded was using glog to log, which it should not have been. Plus, the event information is inherently structured, so it's a win to provide structured logging of the event. We probably want to have the recorder have a unique logger per controller (or consumer in general) -- right now, it's just using the glog manager logger.
This returns glog from the admission internals. It also fixes a case where we fail to marshal a response, and then try and write that empty marshalled response anyway.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
@droot FYI |
droot
approved these changes
Aug 24, 2018
Since we don't directly depend on glog any more, we can remove it from Gopkg.toml.
DirectXMan12
force-pushed
the
bug/glog-hunting-mark-2
branch
from
9412b83 to
78ef8b2
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
justinsb
pushed a commit
to justinsb/controller-runtime
that referenced
this pull request
Dec 7, 2018
…ting-mark-2 glog elimination round 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glog seems to have a way of creeping back in to our codebase. If you see it in code review, point it out -- you should be using logr instead.