Skip to content

gas linter renamed to gosec #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2018
Merged

gas linter renamed to gosec #126

merged 1 commit into from
Aug 29, 2018

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Aug 29, 2018 •
edited
Loading

This PR fixes an failing linter check due to renaming.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 29, 2018
@mengqiy mengqiy changed the title gas linter renamed to gosec [WIP] gas linter renamed to gosec Aug 29, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2018
@mengqiy
Copy link
Member Author

mengqiy commented Aug 29, 2018

It can be found failing in previous Travis run: https://travis-ci.org/kubernetes-sigs/controller-runtime/jobs/422318277

@mengqiy mengqiy changed the title [WIP] gas linter renamed to gosec gas linter renamed to gosec Aug 29, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2018
@mengqiy mengqiy removed the request for review from pwittrock August 29, 2018 23:35
droot
droot approved these changes Aug 29, 2018
View reviewed changes
Copy link
Contributor

@droot droot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

hack/verify.sh
@@ -39,7 +39,7 @@ gometalinter.v2 --disable-all \
--enable=errcheck \
--enable=varcheck \
--enable=goconst \
--enable=gas \
--enable=gosec \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean, contributors will have to update the metalinter ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They don't have to.
The Travis has this problem is because it always get the latest one.
https://github.com/kubernetes-sigs/controller-runtime/blob/master/.travis.yml#L18

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2018
@mengqiy mengqiy added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3db8d34 into kubernetes-sigs:master Aug 29, 2018
@mengqiy mengqiy deleted the gas branch August 29, 2018 23:53
This was referenced Aug 29, 2018
Merged
Merged
justinsb pushed a commit to justinsb/controller-runtime that referenced this pull request Dec 7, 2018
@k8s-ci-robot
Merge pull request kubernetes-sigs#126 from mengqiy/gas
5b8572f 
gas linter renamed to gosec
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
Merge pull request #126 from pwittrock/docs-gen
158c292 
Stop using apiserver for generating docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot droot approved these changes

Assignees

@droot droot

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mengqiy @k8s-ci-robot @droot