✨ Fix some typos #1312
Merged
✨ Fix some typos #1312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates resouces to resources in pkg/client noConversionParamCodec. Signed-off-by: hasheddan <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Updates comment in metatdata listwatch creation to read listwatch instead of listwaatch. Signed-off-by: hasheddan <[email protected]>
k8s-ci-robot
removed
the
lgtm
|
/assign @alvaroaleman |
alvaroaleman
approved these changes
Jan 2, 2021
k8s-ci-robot
added
tide/merge-method-squash
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, hasheddan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
RainbowMango
pushed a commit
to RainbowMango/controller-runtime
that referenced
this pull request
Sep 1, 2021
* Fix minor typo in client codec Updates resouces to resources in pkg/client noConversionParamCodec. Signed-off-by: hasheddan <[email protected]> * Fix minor listwatch comment typo Updates comment in metatdata listwatch creation to read listwatch instead of listwaatch. Signed-off-by: hasheddan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates resouces to resources in pkg/client noConversionParamCodec.
Signed-off-by: hasheddan [email protected]