Skip to content

Support optional identifier for handlers #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Support optional identifier for handlers #150

wants to merge 1 commit into from

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Sep 18, 2018 •
edited
Loading

One handler may represent a feature and people may want to disable a feature at runtime.
So a handler should have an optional identifier.

@mengqiy mengqiy requested a review from droot September 18, 2018 23:21
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 18, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mengqiy
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: pwittrock

If they are not already assigned, you can assign the PR to them by writing /assign @pwittrock in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 18, 2018
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2018
@mengqiy mengqiy changed the title [WIP] Support disabling handlers in webhook Support optional identifier for handlers Sep 19, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2018
droot
droot reviewed Sep 19, 2018
View reviewed changes
pkg/webhook/admission/webhook.go
type NameGetter interface {
// Name returns the name of the Handler.
// The name should be a feature name that can be the identifier for the handler.
Name() string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need to exist in the controller-runtime IMO.

@mengqiy
Copy link
Member Author

mengqiy commented Sep 19, 2018

Had an offline discussion with @droot, I agree we don't need to have the NameGetter in the controller-runtime lib at least for now.

@mengqiy mengqiy closed this Sep 19, 2018
@mengqiy mengqiy deleted the disable_knob branch September 19, 2018 21:07
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
Merge pull request #150 from fanzhangio/issue128
cbcbf1d 
Add more support for CRD validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot droot left review comments

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mengqiy @k8s-ci-robot @droot