🐛 Quote path with -p env in envtest-setup #1513
Merged
+132
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path could have spaces, single quotes, etc in in, so this quotes the path and escapes single quotes so we can export properly.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
FYI @vincepri |
vincepri
approved these changes
May 5, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
hmm... looks like a flaky timing test? Occaisional timeouts waiting for etcd of kube-apiserver to start, esp on the "it should be fast to set up and tear down" tests. /retest |
estroz
reviewed
May 5, 2021
| // - shell strings that are next to each other are concatenated (so "a""b""c" == "abc") | ||
| // - you can intermix quote styles using the above | ||
| // - so `'"'"'` --> CLOSE_QUOTE + "'" + OPEN_QUOTE | ||
| shellQuoted := strings.ReplaceAll(path, "'", `'"'"'`) |
There was a problem hiding this comment.
So the result is supposed to look something like the following?
$ export FOO='/foo/'"'"'Application Support'"'"''
$ echo $FOO
/foo/'Application Support'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path could have spaces, single quotes, etc in in, so this quotes the
path and escapes single quotes so we can export properly.
This is very relevant on darwin, where our default store path contains spaces (it includes "Application Support")