Skip to content

Support for client-go code generated controllers as Controller Watch … #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2018
Merged

Support for client-go code generated controllers as Controller Watch … #159

merged 1 commit into from
Sep 27, 2018

Conversation

pwittrock
Copy link
Contributor

@pwittrock pwittrock commented Sep 25, 2018 •
edited
Loading

This is useful for projects that either:

  1. Want to migrate to controller-runtime client incrementally from client-go generated libraries
  2. Prefer to use the client-go generated libraries

@pwittrock pwittrock requested a review from droot September 25, 2018 01:41
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pwittrock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 25, 2018
@pwittrock pwittrock closed this Sep 25, 2018
@pwittrock pwittrock reopened this Sep 25, 2018
@DirectXMan12
Copy link
Contributor

Can you add a description of "why" for posterity? Even just "this makes it easier for existing projects to incrementally migrate to controller-runtime" or such.

DirectXMan12
DirectXMan12 suggested changes Sep 25, 2018
View reviewed changes
Copy link
Contributor

@DirectXMan12 DirectXMan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo a PR description, this looks good to me

@pwittrock
Copy link
Contributor Author

@DirectXMan12 Done

droot
droot approved these changes Sep 25, 2018
View reviewed changes
pkg/source/source.go
ks.Informer.AddEventHandler(internal.EventHandler{Queue: queue, EventHandler: handler, Predicates: prct})
return nil
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking more about the code in the manager's main fn, I am wondering if we need to add the concept of Source being ready (in this case, informed being sync'ed) from the perspective of wiring everything. Will have to look at the code to reason more about it.

@DirectXMan12
Copy link
Contributor

@droot for your comment above, is that a "I want to look at this pre-merge" or "I want to look at this post-merge"

@droot
Copy link
Contributor

droot commented Sep 26, 2018

is that a "I want to look at this pre-merge" or "I want to look at this post-merge"

Oh, sorry, I wasn't clear. I meant "post-merge", so I am good with the change.

@DirectXMan12
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2018
@k8s-ci-robot k8s-ci-robot merged commit 5bccddb into kubernetes-sigs:master Sep 27, 2018
justinsb pushed a commit to justinsb/controller-runtime that referenced this pull request Dec 7, 2018
@k8s-ci-robot
Merge pull request kubernetes-sigs#159 from pwittrock/master
c893a79 
Support for client-go code generated controllers as Controller Watch …
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
@droot
Merge pull request #159 from pwittrock/docs-gen
cb7ddfc 
Upgrading Kubebuilder and Core Only Controller docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirectXMan12 DirectXMan12 DirectXMan12 approved these changes

@droot droot droot approved these changes

Assignees

@DirectXMan12 DirectXMan12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pwittrock @k8s-ci-robot @DirectXMan12 @droot