pkg/client: Pass ctx to typedClient requests #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
darkowlzz
changed the title
This change passes the context in the client methods to the underlying object requests created using client-go's Request for typedClient. Context isn't passed to the unstructuredClient because the dynamicResourceClient in client-go doesn't accepts any context.
darkowlzz
force-pushed
the
40-pkg/client-respect-context
branch
from
370534b to
11794f8
Compare
darkowlzz
changed the title
|
/lgtm Good catch! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: darkowlzz, DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
justinsb
pushed a commit
to justinsb/controller-runtime
that referenced
this pull request
Dec 7, 2018
…espect-context pkg/client: Pass ctx to typedClient requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change passes the context in the client methods to the underlying
object requests created using client-go's Request for
typedClient.Context isn't passed to the
unstructuredClientbecause thedynamicResourceClientin client-go doesn't accepts any context.Fixes #40