Skip to content

Adding documentation for using unstructured for client and controller #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shawn-hurley
Copy link

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 26, 2018
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 26, 2018
@shawn-hurley shawn-hurley force-pushed the doc/add-unstructured-docs branch from a44d577 to f4df511 Compare October 26, 2018 16:41
Copy link
Contributor

@droot droot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this. Someone requested exactly this yesterday :)

I have couple of minor comments.

c client.Client
)

// This example shows how to use the client with typed and unstrucurted objects to retrieve a objects.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be we can say This example shows how to use the client to retrieve typed and unstructured objects

Typo in unstructured.

@shawn-hurley shawn-hurley force-pushed the doc/add-unstructured-docs branch from f4df511 to d31a1c1 Compare October 29, 2018 16:18
@pwittrock
Copy link
Contributor

@shawn-hurley Would you update the GitBook as a follow up?

@shawn-hurley
Copy link
Author

I have not done that before, so I might need a little guidance or a link, but would happily do that :)

@droot droot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 29, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: shawn-hurley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@droot
Copy link
Contributor

droot commented Oct 29, 2018

@shawn-hurley You can look at this PR kubernetes-sigs/kubebuilder#465 for reference. There is this small README for previewing your changes locally.

@k8s-ci-robot k8s-ci-robot merged commit a8ea205 into kubernetes-sigs:master Oct 29, 2018
justinsb pushed a commit to justinsb/controller-runtime that referenced this pull request Dec 7, 2018
…ructured-docs

Adding documentation for using unstructured for client and controller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants