-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Adding documentation for using unstructured for client and controller #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding documentation for using unstructured for client and controller #184
Conversation
a44d577
to
f4df511
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing this. Someone requested exactly this yesterday :)
I have couple of minor comments.
pkg/client/example_test.go
Outdated
c client.Client | ||
) | ||
|
||
// This example shows how to use the client with typed and unstrucurted objects to retrieve a objects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be we can say This example shows how to use the client to retrieve typed and unstructured objects
Typo in unstructured.
f4df511
to
d31a1c1
Compare
@shawn-hurley Would you update the GitBook as a follow up? |
I have not done that before, so I might need a little guidance or a link, but would happily do that :) |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: shawn-hurley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@shawn-hurley You can look at this PR kubernetes-sigs/kubebuilder#465 for reference. There is this small README for previewing your changes locally. |
…ructured-docs Adding documentation for using unstructured for client and controller
No description provided.