Skip to content

Rename InstallWebhookConfig and change it to a pointer #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2018
Merged

Rename InstallWebhookConfig and change it to a pointer #186

merged 1 commit into from
Oct 29, 2018

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Oct 27, 2018 •
edited
Loading

This PR changes an option introduced in #174.

We always install webhook config prior v0.1.5 releases.
We introduced an option InstallWebhookConfig recently and was released on Oct 25 in v0.1.5.

If InstallWebhookConfig is not an pointer, it will be defaulted to false by golang.
That means existing user who are upgrading from previous controller-runtime version will be break, because they expect webhook config installer to be on.

@mengqiy mengqiy requested a review from droot October 27, 2018 00:33
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 27, 2018
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 27, 2018
@droot
Copy link
Contributor

droot commented Oct 29, 2018

So one recommendation, we should invert the flag (--disable-webhook-config-install ? or something)

@mengqiy mengqiy force-pushed the installWebhookConfig_pointer branch from ba09808 to 8ef5d02 Compare October 29, 2018 18:10
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 29, 2018
@mengqiy mengqiy force-pushed the installWebhookConfig_pointer branch from 8ef5d02 to 590a840 Compare October 29, 2018 18:13
@mengqiy
Copy link
Member Author

mengqiy commented Oct 29, 2018

@droot PTAL

@mengqiy mengqiy changed the title change InstallWebhookConfig to pointer Rename InstallWebhookConfig and change it to a pointer Oct 29, 2018
@mengqiy
Copy link
Member Author

mengqiy commented Oct 29, 2018

Renamed InstallWebhookConfig to DisableInstallWebhookConfig as a pointer. LMK if the naming makes sense to you.

@mengqiy mengqiy mentioned this pull request Oct 29, 2018
Closed
droot
droot reviewed Oct 29, 2018
View reviewed changes
Copy link
Contributor

@droot droot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have a renaming suggestion :)

pkg/webhook/server.go Outdated
// during bootstrapping. e.g. webhookConfiguration, service and secret.
InstallWebhookConfig bool
// If false, the server will install the webhook config objects. It is defaulted to false.
DisableInstallWebhookConfig *bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something about the name feels off while reading it. "Disable" and "Install" not going together. One option could be "DisableWebhookConfigAutoInstall" ?

@droot droot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2018
@mengqiy mengqiy force-pushed the installWebhookConfig_pointer branch from 590a840 to ee29740 Compare October 29, 2018 20:35
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2018
@mengqiy
Copy link
Member Author

mengqiy commented Oct 29, 2018

Changed it to DisableWebhookConfigInstaller.
PTAL

@droot droot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 29, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5fd1e9e into kubernetes-sigs:master Oct 29, 2018
@mengqiy mengqiy deleted the installWebhookConfig_pointer branch October 29, 2018 21:10
justinsb pushed a commit to justinsb/controller-runtime that referenced this pull request Dec 7, 2018
@k8s-ci-robot
Merge pull request kubernetes-sigs#186 from mengqiy/installWebhookCon…
df6c22b 
…fig_pointer

Rename InstallWebhookConfig and change it to a pointer
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
Merge pull request #186 from kragniz/travis-osx
e3dfa25 
Add OSX build job to travis config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot droot left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mengqiy @droot @k8s-ci-robot