-
Notifications
You must be signed in to change notification settings - Fork 1.2k
✨ Enable metrics of clientgo leader election #1901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -144,6 +144,9 @@ type controllerManager struct { | |
// webhookServer if unset, and Add() it to controllerManager. | ||
webhookServerOnce sync.Once | ||
|
||
// leaderElectionID is the name of the resource that leader election | ||
// will use for holding the leader lock. | ||
leaderElectionID string | ||
// leaseDuration is the duration that non-leader candidates will | ||
// wait to force acquire leadership. | ||
leaseDuration time.Duration | ||
|
@@ -637,6 +640,7 @@ func (cm *controllerManager) startLeaderElection(ctx context.Context) (err error | |
}, | ||
}, | ||
ReleaseOnCancel: cm.leaderElectionReleaseOnCancel, | ||
Name: cm.leaderElectionID, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TILd |
||
}) | ||
if err != nil { | ||
return err | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
package metrics | ||
|
||
import ( | ||
"github.com/prometheus/client_golang/prometheus" | ||
"k8s.io/client-go/tools/leaderelection" | ||
) | ||
|
||
// This file is copied and adapted from k8s.io/component-base/metrics/prometheus/clientgo/leaderelection | ||
// which registers metrics to the k8s legacy Registry. We require very | ||
// similar functionality, but must register metrics to a different Registry. | ||
|
||
var ( | ||
leaderGauge = prometheus.NewGaugeVec(prometheus.GaugeOpts{ | ||
Name: "leader_election_master_status", | ||
zqzten marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Help: "Gauge of if the reporting system is master of the relevant lease, 0 indicates backup, 1 indicates master. 'name' is the string used to identify the lease. Please make sure to group by name.", | ||
}, []string{"name"}) | ||
) | ||
|
||
func init() { | ||
Registry.MustRegister(leaderGauge) | ||
leaderelection.SetProvider(leaderelectionMetricsProvider{}) | ||
} | ||
|
||
type leaderelectionMetricsProvider struct{} | ||
|
||
func (leaderelectionMetricsProvider) NewLeaderMetric() leaderelection.SwitchMetric { | ||
return &switchAdapter{gauge: leaderGauge} | ||
} | ||
|
||
type switchAdapter struct { | ||
gauge *prometheus.GaugeVec | ||
} | ||
|
||
func (s *switchAdapter) On(name string) { | ||
s.gauge.WithLabelValues(name).Set(1.0) | ||
} | ||
|
||
func (s *switchAdapter) Off(name string) { | ||
s.gauge.WithLabelValues(name).Set(0.0) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.