Update godocs after refactor #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/L
droot
reviewed
Jun 12, 2018
pkg/controller/example_test.go
Outdated
| @@ -30,7 +30,21 @@ import ( | |||
|
|
|||
| var mrg manager.Manager | |||
|
|
|||
| // This example creates a new controller named "pod-controller" with a no-op reconcile function and registers | |||
| // This example creates a new Controller named "pod-controller" with a no-op reconcile function. The | |||
| // manager.Manager mrg will be used to Start the Controller, and will provide it a shared Cache and Client. | |||
There was a problem hiding this comment.
nit: mrg --> mgr (looks like your IDE has picked mrg instead of mgr) ?
|
|
||
| * Users SHOULD use the provided Source implementations instead of implementing their own for nearly all cases. | ||
|
|
||
| EventHandler |
There was a problem hiding this comment.
We made changes to naming in EventHandler I think ?
There was a problem hiding this comment.
The interface stil EventHandler
|
|
||
| * Example: Pod events for a ReplicaSet are transformed to a ReplicaSet name / Namespace, so the ReplicaSet | ||
| will be Reconciled only 1 time for multiple Pods. | ||
| */ |
There was a problem hiding this comment.
This is a nice doc write up. +1
pwittrock
added
approved
justinsb
pushed a commit
to justinsb/controller-runtime
that referenced
this pull request
Dec 7, 2018
Update godocs after refactor
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
Update README.md release links
stevekuznetsov
pushed a commit
to stevekuznetsov/controller-runtime
that referenced
this pull request
Oct 10, 2022
Rebase: kcp-0.7+ / kube 1.24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.