🏃 Add default PR template #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The template picker only works for issues, but you can still have multiple PR templates that can be used with a query parameter, but that's kind-of unweildy. We'll have the default PR template, and keep the separate ones around linked-to from the readme as examples.
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/M
|
/kind cleanup |
k8s-ci-robot
added
the
kind/cleanup
droot
added
the
lgtm
justinsb
pushed a commit
to justinsb/controller-runtime
that referenced
this pull request
Dec 7, 2018
…-templates 🏃 Add default PR template
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
Add links to slack, googlegroup resources to GitBook and README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template picker only works for issues, but you can still have
multiple PR templates that can be used with a query parameter, but
that's kind-of unweildy. We'll have the default PR template, and keep
the separate ones around linked-to from the readme as examples.