Skip to content

[WIP] 🏃 External k8s.io References Checker #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DirectXMan12
Copy link
Contributor

This introduces a tool for checking all our external references to
Kubernetes in our public API surface, so that we can make sure we don't
accidentally break people in an update due to changing Kubernetes API
surface.

This introduces a tool for checking all our external references to
Kubernetes in our public API surface, so that we can make sure we don't
accidentally break people in an update due to changing Kubernetes API
surface.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 1, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 1, 2018
@DirectXMan12
Copy link
Contributor Author

cc @droot @mengqiy @pwittrock part one of the tooling

@DirectXMan12 DirectXMan12 changed the title 🏃 External k8s.io References Checker [WIP] 🏃 External k8s.io References Checker Dec 1, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2018
@DirectXMan12
Copy link
Contributor Author

(may need a bit of cleanup before merge, but wanted to get it up for review)

@DirectXMan12
Copy link
Contributor Author

Note to future self: it looks like there's a prebuilt version of something similar to this hiding in https://godoc.org/golang.org/x/exp/apidiff. I can probably make use of it to simplify this code.

@mengqiy
Copy link
Member

mengqiy commented Jan 8, 2019

@DirectXMan12 Just be aware of x/exp/apidiff is still experimental and not stable. That mean each time we upgrade to a newer go version, it may break.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 28, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 28, 2019
@DirectXMan12
Copy link
Contributor Author

closing, but I'll bring this back at some point

DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
Add e2e test for kubebuilder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants