-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[WIP] 🏃 External k8s.io References Checker #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] 🏃 External k8s.io References Checker #229
Conversation
This introduces a tool for checking all our external references to Kubernetes in our public API surface, so that we can make sure we don't accidentally break people in an update due to changing Kubernetes API surface.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cc @droot @mengqiy @pwittrock part one of the tooling |
(may need a bit of cleanup before merge, but wanted to get it up for review) |
Note to future self: it looks like there's a prebuilt version of something similar to this hiding in https://godoc.org/golang.org/x/exp/apidiff. I can probably make use of it to simplify this code. |
@DirectXMan12 Just be aware of |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
closing, but I'll bring this back at some point |
Add e2e test for kubebuilder
This introduces a tool for checking all our external references to
Kubernetes in our public API surface, so that we can make sure we don't
accidentally break people in an update due to changing Kubernetes API
surface.