Skip to content

🌱 Add a prefix to the stack trace printed after SetLogger timeout #2357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2023
Merged

🌱 Add a prefix to the stack trace printed after SetLogger timeout #2357

merged 1 commit into from
Jul 19, 2023

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented May 26, 2023 •
edited
Loading

Example:

[controller-runtime] log.SetLogger(...) was never called; logs will not be displayed. Detected at:
	>  goroutine 1 [running]:
	>  runtime/debug.Stack()
	>  	/usr/local/go-faketime/src/runtime/debug/stack.go:24 +0x65
	>  main.main()
	>  	/tmp/sandbox4160348257/prog.go:13 +0x2b

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 26, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 26, 2023
seh
seh reviewed May 26, 2023
View reviewed changes
@vincepri vincepri force-pushed the log-stack-prefix branch from 2544562 to 4d9c115 Compare May 26, 2023 15:56
seh
seh reviewed May 26, 2023
View reviewed changes
@vincepri vincepri force-pushed the log-stack-prefix branch from 4d9c115 to 95885c7 Compare May 26, 2023 16:02
seh
seh reviewed May 26, 2023
View reviewed changes
@vincepri vincepri force-pushed the log-stack-prefix branch from 95885c7 to fdf6f6d Compare May 26, 2023 16:08
seh
seh reviewed May 26, 2023
View reviewed changes
@sbueringer
Copy link
Member

sbueringer commented Jul 18, 2023 •
edited
Loading

Entirely missed this PR. @vincepri can you address this one: #2357 (comment). I think then we can merge it

(would be nice if you can update the PR description with the final version after the last few changes)

@vincepri
Copy link
Member Author

@sbueringer done

@sbueringer
Copy link
Member

Thank you very much. Looks good

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [sbueringer,vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 93dd4b0 into kubernetes-sigs:main Jul 19, 2023
@Icarus9913 Icarus9913 mentioned this pull request Oct 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seh seh seh left review comments

@FillZpp FillZpp Awaiting requested review from FillZpp

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vincepri @sbueringer @k8s-ci-robot @seh