Client tests #27
Merged
Client tests #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
seans3
suggested changes
Jun 12, 2018
pkg/client/client.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| if isNamespaced(mapping) { | ||
| return client.Put(). | ||
| Namespace(meta.GetNamespace()). |
There was a problem hiding this comment.
There is a version of this method called "NamespaceIfScoped" which would simplify this "if" block.
pkg/client/client.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| if isNamespaced(mapping) { | ||
| return client.Delete(). | ||
| Namespace(meta.GetNamespace()). |
There was a problem hiding this comment.
Same comment about "NamespaceIfScoped"
pkg/client/client.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| if isNamespaced(mapping) { | ||
| return client.Get(). | ||
| Namespace(key.Namespace). |
There was a problem hiding this comment.
Same comment about "NamspaceIfScoped".
pkg/client/client.go
Outdated
| ns = opts.Namespace | ||
| if isNamespaced(mapping) && opts != nil && len(opts.Namespace) > 0 { | ||
| return client.Get(). | ||
| Namespace(opts.Namespace). |
There was a problem hiding this comment.
Same comment about "NamespaceIfScoped"
| // ReadInterface knows how to read and list Kubernetes objects. | ||
| type ReadInterface interface { | ||
| // Reader knows how to read and list Kubernetes objects. | ||
| type Reader interface { |
There was a problem hiding this comment.
Reader is a better interface name.
| // WriteInterface knows how to create, delete, and update Kubernetes objects. | ||
| type WriteInterface interface { | ||
| // Writer knows how to create, delete, and update Kubernetes objects. | ||
| type Writer interface { |
There was a problem hiding this comment.
Writer is a better interface name.
pwittrock
force-pushed
the
client
branch
2 times, most recently
from
34cf975 to
a9d2f7b
Compare
|
PTAL |
seans3
approved these changes
Jun 13, 2018
pkg/client/client.go
Outdated
| return nil, nil, "", err | ||
| } | ||
| return meta, client, resource, err | ||
| // client is a client.Client that reads and writes directly from/to an API server. It lazily initialized |
There was a problem hiding this comment.
Small grammar nit: It lazily "initializes" ...
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
Addressed the comments. PTAL. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
removed
the
lgtm
pwittrock
added
approved
justinsb
pushed a commit
to justinsb/controller-runtime
that referenced
this pull request
Dec 7, 2018
Client tests
stevekuznetsov
pushed a commit
to stevekuznetsov/controller-runtime
that referenced
this pull request
Oct 10, 2022
✨ Update to newer kcp apimachinery, logicalcluster packages
This was referenced Mar 24, 2025
Open
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.