✨ Trim Gopkg.toml #353
Closed
✨ Trim Gopkg.toml #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
sig/api-machinery
droot
added
the
lgtm
|
lgtm'd it, but needs a rebase. |
DirectXMan12
force-pushed
the
refactor/trim-gopkg-toml
branch
from
9c886d2 to
428cc86
Compare
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
This removes the "required" markings from Gopkg.toml, pins logr and zapr at specific versions, and prunes non-go. This should start to reduce our dependency list.
This removes v from Gopkg.toml version fields (while not technically incorrect, it's also not correct according to dep documentation).
DirectXMan12
force-pushed
the
refactor/trim-gopkg-toml
branch
from
428cc86 to
610e845
Compare
|
Since we have moved to Go modules, it is probably safe to close this one now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some issues in our Gopkg.toml (ghodss/yaml --> sigs.k8s.io/yaml, normalizing 'v' vs no 'v' in version strings), sets more aggressive pruning, and removes the "required" marks, which should cut down on dependency bloat in CR.