Skip to content

Fakeclient #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2018
Merged

Fakeclient #36

merged 2 commits into from
Jun 15, 2018

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Jun 14, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 14, 2018
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 14, 2018
@mengqiy mengqiy requested review from droot and pwittrock and removed request for apelisse and derekwaynecarr June 14, 2018 17:19
@mengqiy mengqiy force-pushed the fakeclient branch 2 times, most recently from 8f6a6db to 375b0dd Compare June 14, 2018 17:33
droot
droot reviewed Jun 14, 2018
View reviewed changes
Copy link
Contributor

@droot droot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @mengqiy This is really useful. LGTM.

@pwittrock pwittrock added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 14, 2018
@pwittrock
Copy link
Contributor

@mengqiy Would you add tests for this?

@apelisse
Copy link

And doc maybe? =)

@mengqiy
Copy link
Member Author

mengqiy commented Jun 15, 2018

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2018
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2018
@mengqiy
Copy link
Member Author

mengqiy commented Jun 15, 2018

/cancelhold

@mengqiy mengqiy removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2018
@mengqiy
Copy link
Member Author

mengqiy commented Jun 15, 2018 •
edited
Loading

75% coverage currently

@pwittrock pwittrock added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 15, 2018
@k8s-ci-robot k8s-ci-robot merged commit c426878 into kubernetes-sigs:master Jun 15, 2018
@mengqiy mengqiy deleted the fakeclient branch June 15, 2018 17:03
justinsb pushed a commit to justinsb/controller-runtime that referenced this pull request Dec 7, 2018
@k8s-ci-robot
Merge pull request kubernetes-sigs#36 from mengqiy/fakeclient
8777299 
Fakeclient
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
@seans3
Merge pull request #36 from seans3/docs-update
0ddf457 
Controller type: StatefulSet versus Deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot droot left review comments

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mengqiy @pwittrock @apelisse @k8s-ci-robot @droot