Skip to content

:sparkles, minor: Switch gometalinter.v2 with golangci-lint #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

:sparkles, minor: Switch gometalinter.v2 with golangci-lint #393

wants to merge 3 commits into from

Conversation

alaypatel07
Copy link
Contributor

@alaypatel07 alaypatel07 commented Apr 11, 2019 •
edited
Loading

This PR replaces gometalinter.v2 with golangci-lint

Fixes #384

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 11, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 11, 2019
@alaypatel07
Copy link
Contributor Author

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 11, 2019
@alaypatel07
Copy link
Contributor Author

/assign @DirectXMan12

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alaypatel07
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: directxman12

If they are not already assigned, you can assign the PR to them by writing /assign @directxman12 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alaypatel07
Copy link
Contributor Author

/cc @shawn-hurley

shawn-hurley
shawn-hurley reviewed Apr 22, 2019
View reviewed changes
pkg/source/source_test.go
@@ -350,7 +350,7 @@ var _ = Describe("Source", func() {
if eventCount == 0 {
<-unblock
}
eventCount += 1
eventCount++
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this change should be apart of this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint check was failing because of eventCount += 1. I figured it would break the CI if I did not make the minor change. Thoughts on how to handle it?

rajathagasthya
rajathagasthya reviewed May 8, 2019
View reviewed changes
hack/verify.sh
--deadline 5m \
--enable=misspell \
--enable=structcheck \
--enable=golint \
--enable=deadcode \
--enable=goimports \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dupe of L68?

@DirectXMan12
Copy link
Contributor

rolled in to #414

@k8s-ci-robot
Copy link
Contributor

@alaypatel07: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2019
@mengqiy
Copy link
Member

mengqiy commented May 17, 2019

Closing in favor of #414

@mengqiy mengqiy closed this May 17, 2019
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
@droot
Merge pull request #393 from albertoleal/fix-contributing-guide
5d4c23c 
Update contributing guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawn-hurley shawn-hurley shawn-hurley left review comments

@rajathagasthya rajathagasthya rajathagasthya left review comments

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@droot droot Awaiting requested review from droot

Assignees

@DirectXMan12 DirectXMan12

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

switch to golangci-lint instead of gometalinter
6 participants
@alaypatel07 @k8s-ci-robot @DirectXMan12 @mengqiy @shawn-hurley @rajathagasthya