:sparkles, minor [WIP] Autoload on tls changes #395
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: anthonyho007 If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
size/XXL
|
@anthonyho007: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-rebase
| for { | ||
| select { | ||
| case event := <-watcher.Events: | ||
| if event.Op&fsnotify.Write == fsnotify.Write { |
There was a problem hiding this comment.
I doubt if it will work, since when a secret get updated it actually triggers a rename event. Ref: algorithm of volume writer.
| if err != nil { | ||
| return err | ||
| } | ||
| defer watcher.Close() |
There was a problem hiding this comment.
function autoloadTLS is not waiting for the child goroutine you created in line 66.
So when it finishes the execution and the watcher is closed. The child goroutine is not doing anything useful anymore.
| log logr.Logger | ||
| } | ||
|
|
||
| func (w *wrappedTLS) setLogger(logger logr.Logger) error { |
There was a problem hiding this comment.
It seems this functions is not used anywhere.
|
Sorry for the late review. |
|
Closing in favor of #421 |
To be update description
Fixes:
#390