Skip to content

🏃 use 👻 for no release note commits #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions VERSIONING.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,10 @@ a:
- Patch fix: :bug: (`:bug:`)
- Docs: :book: (`:book:`)
- Infra/Tests/Other: :running: (`:running:`)
- No release note: :ghost: (`:ghost:`)

Use :ghost: (no release note) only for the PRs that change or revert unreleased
changes, which don't deserve a release note. Please don't abuse it.

You can also use the equivalent emoji directly, since GitHub doesn't
render the `:xyz:` aliases in PR titles.
Expand Down
4 changes: 4 additions & 0 deletions hack/release/common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ cr_major_pattern=":warning:|$(printf "\xe2\x9a\xa0")"
cr_minor_pattern=":sparkles:|$(printf "\xe2\x9c\xa8")"
cr_patch_pattern=":bug:|$(printf "\xf0\x9f\x90\x9b")"
cr_docs_pattern=":book:|$(printf "\xf0\x9f\x93\x96")"
cr_no_release_note_pattern=":ghost:|$(printf "\xf0\x9f\x91\xbb")"
cr_other_pattern=":running:|$(printf "\xf0\x9f\x8f\x83")"

# cr::symbol-type-raw turns :xyz: and the corresponding emoji
Expand All @@ -24,6 +25,9 @@ cr::symbol-type-raw() {
@(${cr_docs_pattern})?('!'))
echo "docs"
;;
@(${cr_no_release_note_pattern})?('!'))
echo "no_release_note"
;;
@(${cr_other_pattern})?('!'))
echo "other"
;;
Expand Down
2 changes: 1 addition & 1 deletion hack/release/release-notes.sh
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ while read commit_word commit; do
patch)
bugfixes="${bugfixes}- ${pr_title} (#${pr_number})${NEWLINE}"
;;
docs|other)
docs|no_release_note|other)
# skip non-code-changes
;;
unknown)
Expand Down