👻 ff release-0.2 branch to master #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This supports generating release notes when we cross "major" version boundaries and need to create a new release branch.
Someone erroneously performed a global case-insensitive s/Reconcile/Reconciler/g, which resulted in bad docs statements such as "Setup a new controller to _Reconciler_ ReplicaSets" and "Reconciler is called to _Reconciler_ an object by Namespace/Name", which should obviously be "Setup a new controller to _reconcile_ ReplicaSets" and "Reconciler is called to _reconcile_ an object..."
This watches the configured TLS certificate and key files for admission webhooks. On any change, it attempts to reload them from disk.
✨ webhook: Handle TLS certificate rotation
✨ webhook server doesn't use leader election by default
We need to set "success" status in conversion response when we successfully convert the object. kube-apiserver rejects it if the status is not set.
📖 Fix docs & comments referring to "Reconciler" instead of "reconcile"
🐛 set status in conversion response
📖 (:book:, docs) Update contributing.md to use golangci-lint
🐛 update internal controller for more clean code and metrics
✨ Allow setting "UseExistingCluster" via environment
This switches the default controller name in the builder to just lower(<kind>) which fixes any issues that arrise from it showing up in the deprecated metrics (which use the workqueue name as part of the metric name). It also allows overriding name in case of two controllers reconciling the same type using the builder.
…ult-name ✨ Allow setting controller name, fix default
Support bridging the control plane output to the stdout and stderr
…ersion 🏃 support release notes on new version
✨ more visibility of the testing control plane
👻 add webhook markers in the example
🏃 use 👻 for no release note commits
This introduces a GitHub action that verifies emoji. We could move this to prow, but in the mean time, it can live here.
🏃 Verify Emoji with GH actions
🐛 Fix runnable race in manager
k8s-ci-robot
added
size/XL
mengqiy
changed the title
|
close and reopen to make the |
|
verify-emoji should run on any pr change (including title upates). it just might take a moment |
droot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: mengqiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
Fix typos: runing->running, genrating->generating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.