Fix non-cache client list #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/M
|
@droot this should fix your issues. The test in the style of the rest of the tests in this package is currently failing. Need to figure out why, but this PR should fix your issue. |
DirectXMan12
force-pushed
the
bug/client-list
branch
from
66185c2 to
0083913
Compare
|
brainfart on the test. should be working now |
k8s-ci-robot
added
the
lgtm
This fixes the non-cache client list, which had a null pointer dereference (opts.Namespace), incorrect resource handling (need the resource for the items, not the list itself), and incorrect handling of nil list options (the underlying metav1.ListOptions needs to always be non-nil, even if empty).
DirectXMan12
force-pushed
the
bug/client-list
branch
from
0083913 to
fca306d
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
pwittrock
added
the
approved
justinsb
pushed a commit
to justinsb/controller-runtime
that referenced
this pull request
Dec 7, 2018
Fix non-cache client list
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
Fix an issue in types.ReconcileKey.String()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the non-cache client list, which had a null pointer
dereference (opts.Namespace), incorrect resource handling (need the
resource for the items, not the list itself), and incorrect handling of
nil list options (the underlying metav1.ListOptions needs to always be
non-nil, even if empty).