Skip to content

✨ Fix typo #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2019
Merged

✨ Fix typo #496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,6 @@
*.swp
*.swo
*~

# Vscode files
.vscode
20 changes: 10 additions & 10 deletions pkg/client/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ var _ = Describe("Client", func() {
close(done)
})

It("should fail if the object does not exists", func(done Done) {
It("should fail if the object does not exist", func(done Done) {
cl, err := client.New(cfg, client.Options{})
Expect(err).NotTo(HaveOccurred())
Expect(cl).NotTo(BeNil())
Expand Down Expand Up @@ -578,7 +578,7 @@ var _ = Describe("Client", func() {

close(done)
})
It("should fail if the object does not exists", func(done Done) {
It("should fail if the object does not exist", func(done Done) {
cl, err := client.New(cfg, client.Options{})
Expect(err).NotTo(HaveOccurred())
Expect(cl).NotTo(BeNil())
Expand Down Expand Up @@ -672,7 +672,7 @@ var _ = Describe("Client", func() {
close(done)
})

It("should fail if the object does not exists", func(done Done) {
It("should fail if the object does not exist", func(done Done) {
cl, err := client.New(cfg, client.Options{})
Expect(err).NotTo(HaveOccurred())
Expect(cl).NotTo(BeNil())
Expand Down Expand Up @@ -791,7 +791,7 @@ var _ = Describe("Client", func() {
close(done)
})

It("should fail if the object does not exists", func(done Done) {
It("should fail if the object does not exist", func(done Done) {
cl, err := client.New(cfg, client.Options{})
Expect(err).NotTo(HaveOccurred())
Expect(cl).NotTo(BeNil())
Expand Down Expand Up @@ -860,7 +860,7 @@ var _ = Describe("Client", func() {
close(done)
})

It("should fail if the object does not exists", func(done Done) {
It("should fail if the object does not exist", func(done Done) {
cl, err := client.New(cfg, client.Options{})
Expect(err).NotTo(HaveOccurred())
Expect(cl).NotTo(BeNil())
Expand Down Expand Up @@ -956,7 +956,7 @@ var _ = Describe("Client", func() {
close(done)
})

It("should fail if the object does not exists", func(done Done) {
It("should fail if the object does not exist", func(done Done) {
cl, err := client.New(cfg, client.Options{})
Expect(err).NotTo(HaveOccurred())
Expect(cl).NotTo(BeNil())
Expand Down Expand Up @@ -1024,7 +1024,7 @@ var _ = Describe("Client", func() {
close(done)
})

It("should fail if the object does not exists", func(done Done) {
It("should fail if the object does not exist", func(done Done) {
cl, err := client.New(cfg, client.Options{})
Expect(err).NotTo(HaveOccurred())
Expect(cl).NotTo(BeNil())
Expand Down Expand Up @@ -1136,7 +1136,7 @@ var _ = Describe("Client", func() {
err = cl.Patch(context.TODO(), u, client.ConstantPatch(types.MergePatchType, mergePatch))
Expect(err).NotTo(HaveOccurred())

By("validating pathed Node has new annotation")
By("validating patched Node has new annotation")
actual, err := clientset.CoreV1().Nodes().Get(nodeName, metav1.GetOptions{})
Expect(err).NotTo(HaveOccurred())
Expect(actual).NotTo(BeNil())
Expand Down Expand Up @@ -1240,7 +1240,7 @@ var _ = Describe("Client", func() {
close(done)
})

It("should fail if the object does not exists", func(done Done) {
It("should fail if the object does not exist", func(done Done) {
cl, err := client.New(cfg, client.Options{})
Expect(err).NotTo(HaveOccurred())
Expect(cl).NotTo(BeNil())
Expand Down Expand Up @@ -1345,7 +1345,7 @@ var _ = Describe("Client", func() {
close(done)
})

It("should fail if the object does not exists", func(done Done) {
It("should fail if the object does not exist", func(done Done) {
cl, err := client.New(cfg, client.Options{})
Expect(err).NotTo(HaveOccurred())
Expect(cl).NotTo(BeNil())
Expand Down
2 changes: 0 additions & 2 deletions pkg/client/options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ type DeleteOptions struct {
// AsDeleteOptions returns these options as a metav1.DeleteOptions.
// This may mutate the Raw field.
func (o *DeleteOptions) AsDeleteOptions() *metav1.DeleteOptions {

if o == nil {
return &metav1.DeleteOptions{}
}
Expand Down Expand Up @@ -309,7 +308,6 @@ type UpdateOptions struct {
// AsUpdateOptions returns these options as a metav1.UpdateOptions.
// This may mutate the Raw field.
func (o *UpdateOptions) AsUpdateOptions() *metav1.UpdateOptions {

if o == nil {
return &metav1.UpdateOptions{}
}
Expand Down