Added tests #52
Merged
Added tests #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
seans3
commented
Jun 19, 2018
seans3
commented
- Added "List" tests
- Added "ListOptions" tests
- Coverage is now 93.0%
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/assign droot |
k8s-ci-robot
added
the
lgtm
droot
reviewed
Jun 19, 2018
| Expect(1).To(Equal(len(deps.Items))) | ||
| actual := deps.Items[0] | ||
| Expect(actual.Name).To(Equal("deployment-frontend")) | ||
|
|
There was a problem hiding this comment.
would be great if we can can another List() call here for all-namespaces and we get both the deployments. That will cover all the namespace based filtering.
There was a problem hiding this comment.
Yeah, lets follow up with that
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
pwittrock
added
the
approved
justinsb
pushed a commit
to justinsb/controller-runtime
that referenced
this pull request
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.