Implement predicate #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Why not copy the kubebuilder Predicates over: The main ones we need are the ResourceVersionChanged, and the ability to compose predicates with And/Or |
droot
reviewed
Jun 22, 2018
pkg/predicate/predicate.go
Outdated
| logf "sigs.k8s.io/controller-runtime/pkg/runtime/log" | ||
| ) | ||
|
|
||
| var predicateLog = logf.KBLog.WithName("predicate").WithName("eventFilters") |
There was a problem hiding this comment.
Don't we use unified runtime log ?
There was a problem hiding this comment.
I was suggesting to rename predicateLog --> log
droot
reviewed
Jun 27, 2018
pkg/predicate/predicate.go
Outdated
| logf "sigs.k8s.io/controller-runtime/pkg/runtime/log" | ||
| ) | ||
|
|
||
| var predicateLog = logf.KBLog.WithName("predicate").WithName("eventFilters") |
There was a problem hiding this comment.
I was suggesting to rename predicateLog --> log
droot
approved these changes
Jun 28, 2018
droot
added
approved
justinsb
pushed a commit
to justinsb/controller-runtime
that referenced
this pull request
Dec 7, 2018
Implement predicate
sttts
pushed a commit
to sttts/controller-runtime
that referenced
this pull request
Apr 29, 2024
…n.kcp.example 🐛 fix kcp example generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubernetes-sigs/kubebuilder#240