Add helper function for adding OwnerReferences to metav1.Objects #54
+133
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
droot
reviewed
Jun 20, 2018
pkg/manager/internal.go
Outdated
| @@ -132,6 +136,26 @@ func (cm *controllerManager) GetRecorder(name string) record.EventRecorder { | |||
| return cm.recorderProvider.GetEventRecorderFor(name) | |||
| } | |||
|
|
|||
| func (cm *controllerManager) SetControllerReference(owner, object v1.Object) error { | |||
There was a problem hiding this comment.
It feels a bit awkward to add a helper method on controllerManager for this. I get the reasoning that this needs access to scheme which is only available at mgr level. Another way would be have this helper as a function which takes scheme as input (not elegant, but isn't too bad either), WDYT ? (thinking along the lines of io and ioutil)
k8s-ci-robot
added
size/L
droot
approved these changes
Jun 20, 2018
| Describe("SetControllerReference", func() { | ||
| It("should set the OwnerReference if it can find the group version kind", func() { | ||
| rs := &appsv1.ReplicaSet{} | ||
| dep := &extensionsv1beta1.Deployment{ |
There was a problem hiding this comment.
any specific reason we are not using appsv1 instead of extensionsv1beta1 here ?
droot
added
approved
justinsb
pushed a commit
to justinsb/controller-runtime
that referenced
this pull request
Dec 7, 2018
Add helper function for adding OwnerReferences to metav1.Objects
sttts
pushed a commit
to sttts/controller-runtime
that referenced
this pull request
Apr 29, 2024
…by-default 🐛 Instantiate kube index informers by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.