Implement fs writer #57
Conversation
k8s-ci-robot
added
cncf-cla: yes
| limitations under the License. | ||
| */ | ||
|
|
||
| package atomic |
There was a problem hiding this comment.
Is this pkg copied from somewhere ? Was wondering if I can skip reviewing this ?
There was a problem hiding this comment.
Yes, it's from k8s.io/kubernetes/pkg/volume/util.
I wrote that in the 1st commit message.
| Mode: 0666, | ||
| }, | ||
| } | ||
| } |
pkg/admission/cert/writer/fs.go
Outdated
| return map[string]atomic.FileProjection{ | ||
| CACertName: { | ||
| Data: cert.CACert, | ||
| Mode: 0666, |
There was a problem hiding this comment.
I'm curious about this mode. Does it really need to be open to everyone?
There was a problem hiding this comment.
Added a TODO.
Let's figure it out later :)
| return f.doWrite(webhookName) | ||
| } | ||
|
|
||
| func (f *fsCertWriter) overwrite(webhookName string) (*certgenerator.Artifacts, error) { |
There was a problem hiding this comment.
overwrite is the same as write. Can we remove it?
There was a problem hiding this comment.
It's part of the interface.
var _ certReadWriter = &fsCertWriter{}
|
PTAL |
test.sh
Outdated
| @@ -137,7 +137,23 @@ gometalinter.v2 --disable-all \ | |||
| --enable=lll \ | |||
| --dupl-threshold=400 \ | |||
| --enable=dupl \ | |||
| ./pkg/... | |||
| ./pkg/admission/ \ | |||
There was a problem hiding this comment.
Is there any -exclude flag so that you don't need to list all other directories?
There was a problem hiding this comment.
Yeah, found the skip flag.
Updated.
pkg/admission/cert/writer/fs_test.go
Outdated
| vwc = &admissionregistration.ValidatingWebhookConfiguration{ | ||
| TypeMeta: metav1.TypeMeta{ | ||
| APIVersion: "admissionregistration.k8s.io/v1beta1", | ||
| Kind: "MutatingWebhookConfiguration", |
There was a problem hiding this comment.
vwc is declared to be validating web hook configuration, but the Kind filed is mutating webhook configuration.
k8s-ci-robot
added
the
lgtm
mengqiy
added
the
approved
Implement fs writer
As in the commit message, the 1st commit is porting an util pkg from k/k.