Skip to content

📖 Document environment variables supported by envtest #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2019
Merged

📖 Document environment variables supported by envtest #624

merged 2 commits into from
Nov 5, 2019

Conversation

mariantalla
Copy link
Contributor

This is part of kubernetes-sigs/kubebuilder#1000 and a followup to the work in kubernetes-sigs/kubebuilder#1055.

Adds information on envtest environment variables to the GoDoc.

/kind documentation

supported by envtest
@k8s-ci-robot
Copy link
Contributor

Welcome @mariantalla!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 2, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 2, 2019
@mariantalla
Copy link
Contributor Author

/cc @DirectXMan12

@mariantalla mariantalla changed the title 📖 Document environment variables supported by envtest 📖Document environment variables supported by envtest Oct 2, 2019
@mariantalla mariantalla changed the title 📖Document environment variables supported by envtest 📖 Document environment variables supported by envtest Oct 2, 2019
@DirectXMan12
Copy link
Contributor

do those actually show up in the godoc in that position? If so, lgtm, otherwise, maybe just move to the package doc comment.

@mariantalla
Copy link
Contributor Author

mariantalla commented Oct 16, 2019

They show up as part of the documentation on Constants:

image

It would be nice to be able to show the actual defaults (defaultKubebuilderPath, defaultKubebuilderControlPlaneStart/StopTimeout too, but I think that's only possible if they become exported.

[edit] ...or with some godoc sorcery, but it means copy-pasting from right below so, hm, not too sure (this is uncommitted):

image

@mariantalla
Copy link
Contributor Author

Added a small note on defaults, which now shows up like this. Let me know if it doesn't work and I'll revert that one.

image

@mariantalla
Copy link
Contributor Author

👋 Any thoughts on this one?

/assign @DirectXMan12 @pwittrock @droot

@DirectXMan12
Copy link
Contributor

awesome, thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, mariantalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0d1cce8 into kubernetes-sigs:master Nov 5, 2019
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
🏃 Design for CRD version conversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants