-
Notifications
You must be signed in to change notification settings - Fork 1.2k
📖 Document environment variables supported by envtest #624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Document environment variables supported by envtest #624
Conversation
supported by envtest
Welcome @mariantalla! |
/cc @DirectXMan12 |
do those actually show up in the godoc in that position? If so, lgtm, otherwise, maybe just move to the package doc comment. |
They show up as part of the documentation on It would be nice to be able to show the actual defaults ( [edit] ...or with some godoc sorcery, but it means copy-pasting from right below so, hm, not too sure (this is uncommitted): |
👋 Any thoughts on this one? /assign @DirectXMan12 @pwittrock @droot |
awesome, thanks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, mariantalla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
🏃 Design for CRD version conversion
This is part of kubernetes-sigs/kubebuilder#1000 and a followup to the work in kubernetes-sigs/kubebuilder#1055.
Adds information on envtest environment variables to the GoDoc.
/kind documentation