Don't fail envtest if directory is missing #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/S
droot
reviewed
Jun 28, 2018
| @@ -39,6 +39,9 @@ type CRDInstallOptions struct { | |||
| // CRDs is a list of CRDs to install | |||
| CRDs []*apiextensionsv1beta1.CustomResourceDefinition | |||
|
|
|||
| // ErrorIfPathMissing will cause an error if a Path does not exist | |||
| ErrorIfPathMissing bool | |||
There was a problem hiding this comment.
Sensible default in this case would be true, but its the opposite currently. Consider renaming it something like SkipMissingCRDs ? so that default is *to error if files missing".
Which case do you need this ?
There was a problem hiding this comment.
This is necessary for scaffolded projects without custom resources. I ran into this when creating a new controller-only project for deployments. The scaffolded test tried to read the crds, but the directory didn't exist because there were no user defined resources.
We probably want to scaffold this to default to not-error so that the projects work without custom resources, but pick them up if they are added later.
droot
added
approved
justinsb
pushed a commit
to justinsb/controller-runtime
that referenced
this pull request
Dec 7, 2018
Don't fail envtest if directory is missing
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
Set ENTRYPOINT and CMD for Dockerfile.controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.