🐛 Fix informer cache creating pointers to pointers

[DewaldV]

Fixes #656

It appears the code in controller-runtime/pkg/cache/informer_cache.go tries to determine whether the items can be cast to runtime.Object and in the process assumes that the slice's elements are not pointers.

This means that if you have a List whose Items type is []*Item the informer cache will create a cacheTypeValue of **Item which then cannot be case to runtime.Object resulting in an error of:

"error": "cannot get cache for *v1.PrometheusRuleList, its element **v1.PrometheusRule is not a runtime.Object"}

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @DewaldV!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @DewaldV. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DewaldV
To complete the pull request process, please assign directxman12
You can assign the PR to them by writing /assign @directxman12 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[DewaldV]

Hmm, my org has a signed CLA so I expected that check to pass. I'll try and see what's up with that before proceeding here.

[DewaldV]

/check-cla

[DewaldV]

Ok, that should be good now. Apologies for the lapse, I had missed a step when linking my GH account to our org's.

[DewaldV]

/assign @DirectXMan12

[alvaroaleman]

@DewaldV thanks for your PR. Could you add a test for this so we don't regress?
/ok-to-test

And more of a comment, but pretty much all List types I've seen use a list of literals, not a list of pointers. The api conventions don't mention anything about that so I guess its fine.

[DewaldV]

@alvaroaleman Happy to, I'll get another commit with a test done in a bit.

[DewaldV]

Apologies for the delay on this, I've got a basic spike with the tests local but I've been delayed due to some work pressures. I'll try and get some time this week to get the test cleaned up and pushed.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[DirectXMan12]

hey, are you still interested in working on this

[DewaldV]

Apologies for the delay on this.

The testing turned out to be rather complicated as it required creating some CRDs with Lists that use pointers so I stalled in Nov and then it dropped off my radar.

I'm going to put some time aside to get the tests finished up over the coming week so we can get this merged.

We do still need it.

[alvaroaleman]

@DewaldV I ended up needing as well, do you mind if I take your commit from here, add another one with a test on top of it and create a new PR so this gets done in a timely manner?

[DewaldV]

@alvaroaleman I'm happy with that. Appreciate you jumping in on this and apologies for not getting this merged before. 😄

[vincepri]

Closing this in favor of 796

/close

[k8s-ci-robot]

@vincepri: Closed this PR.

In response to this:

Closing this in favor of 796

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.