Skip to content

✨ more visibility of the testing control plane #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Random-Liu
Copy link
Contributor

@Random-Liu Random-Liu commented Dec 4, 2019

Support bridging the control plane output to the stdout and stderr

This is very useful for debugging in CI. Let's cherrypick it to release-0.1 which is the only branch that doesn't have this useful thing. :)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 4, 2019
@Random-Liu
Copy link
Contributor Author

/assign @mengqiy @droot

@mengqiy
Copy link
Member

mengqiy commented Dec 4, 2019

@Random-Liu It seems the linter is not happy.
I guess we can simply diable that linter, we don't expect much more code change into release-0.1 branch.

Support bridging the control plane output to the stdout and stderr
@Random-Liu Random-Liu force-pushed the cherrypick-#459-release-0.1 branch from 432acf1 to 3efda05 Compare December 4, 2019 21:48
@Random-Liu
Copy link
Contributor Author

@mengqiy Added a nolint. Hope it will work.

@mengqiy mengqiy added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit dde0076 into kubernetes-sigs:release-0.1 Dec 4, 2019
@Random-Liu Random-Liu deleted the cherrypick-#459-release-0.1 branch December 4, 2019 22:52
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
….0.0

🏃 updated install instructions to use 2.0.0-alpha.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants