Skip to content

🐛 Remove TotalRequests Prometheus metrics as it is not getting used #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

prafull01
Copy link
Contributor

@prafull01 prafull01 commented Dec 8, 2019

This PR is for the issue #712 TotalRequests prometheus metrics is not getting used and hence it is removed in this PR.

Fixes #712

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 8, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @prafull01. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 8, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 8, 2019
@DirectXMan12 DirectXMan12 changed the title (:bug:, patch) Remove TotalRequests Prometheus metrics as it is not getting used :bug Remove TotalRequests Prometheus metrics as it is not getting used Dec 9, 2019
@DirectXMan12
Copy link
Contributor

FYI: I edited the title to conform to our title standards (the type indicator must be the first thing in the title), removed the comments from the PR description, and added a Fixes #xyz line to the PR. In the future, please try to follow the PR guidelines in the PR template :-)

@DirectXMan12
Copy link
Contributor

/lgtm
/approve

non-breaking due to being in the internal package, and being unused

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, prafull01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2019
@DirectXMan12 DirectXMan12 changed the title :bug Remove TotalRequests Prometheus metrics as it is not getting used 🐛 Remove TotalRequests Prometheus metrics as it is not getting used Dec 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit 201a662 into kubernetes-sigs:master Dec 9, 2019
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
🏃 updated cr/ct version to 0.2.0-beta.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webhook Metric Request Total Unused
3 participants