Skip to content

🏃 use new github action syntax #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

🏃 use new github action syntax #735

wants to merge 2 commits into from

Conversation

alexeldeib
Copy link
Contributor

fixes #610

get those sweet, sweet emoji verified

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 18, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alexeldeib
To complete the pull request process, please assign droot
You can assign the PR to them by writing /assign @droot in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 18, 2019
@alexeldeib alexeldeib force-pushed the ace/ghaction branch 3 times, most recently from c857ede to f4d0281 Compare December 18, 2019 23:51
@alexeldeib
Copy link
Contributor Author

I think github is unhappy because I am trying to merge into the main workflow: https://i.8713187.xyzmunity/t5/GitHub-Actions/GitHub-action-Resource-not-accessible-by-integration/td-p/19707

However I have an up to date fork where this action works fine: https://github.com/alexeldeib/controller-runtime/commit/f4d028132839d6df1e3d815d0f016ca4a4c17724/checks?check_suite_id=365691723

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2019
@alexeldeib
Copy link
Contributor Author

I'm not sure that's the issue, actually. But since actions show up as a check anyway, maybe it's sufficient to leave it like this without the CURL to set status? I guess the text won't pretty print for the unicode emoji, but the check will work at least shrugs

@DirectXMan12 DirectXMan12 changed the title 🏃 use new github action syntax :not-valid-thing: use new github action syntax Jan 6, 2020
@DirectXMan12
Copy link
Contributor

Nice, let's get the check back in place, then I'll play around with the pretty-printing.

DirectXMan12
DirectXMan12 suggested changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@DirectXMan12 DirectXMan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can also move those dockerfile labels into a check metadata file: https://help.github.com/en/actions/automating-your-workflow-with-github-actions/creating-a-docker-container-action#create-an-action-metadata-file

.github/workflows/main.yaml Outdated
@@ -0,0 +1,12 @@
on: pull_request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changed since I originally wrote this, but I think we want to explicitly list types so we get edit as a type here as well: https://help.github.com/en/actions/automating-your-workflow-with-github-actions/events-that-trigger-workflows#pull-request-event-pull_request

hack/release/verify-emoji.sh
@@ -25,5 +25,10 @@ base_link=$(jq -r '.pull_request.url' < ${GITHUB_EVENT_PATH})
head_commit=$(curl -H "Authorization: Bearer ${GITHUB_TOKEN}" -H 'Accept: application/vnd.github.antiope-preview+json' -q ${base_link} | jq -r '.head.sha')
echo "head commit is ${head_commit}"

curl https://api.github.com/repos/${GITHUB_REPOSITORY}/check-runs -XPOST -H "Authorization: Bearer ${GITHUB_TOKEN}" -H 'Accept: application/vnd.github.antiope-preview+json' -H 'Content-Type: application/json' -q --data-raw '{"name": "Verify Emoji", "head_sha": "'${head_commit}'", "conclusion": "'${conclusion}'", "status": "completed", "completed_at": "'$(date -Iseconds)'", "output": {"title": "Verify Emoji", "summary": "'"${summary}"'"}}'
echo ${summary}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's just me, but I'm not actually seeing the output of this in the result. Let me try manually re-running.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, it just shows up way at the bottom. Need to scroll.

@DirectXMan12 DirectXMan12 reopened this Jan 6, 2020
@alexeldeib alexeldeib changed the title :not-valid-thing: use new github action syntax 🏃 use new github action syntax Jan 21, 2020
@alexeldeib
Copy link
Contributor Author

I updated the triggers, but I feel like something weird is happening with the display of the check still..seems like it's showing twice?

@k8s-ci-robot
Copy link
Contributor

@alexeldeib: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-controller-runtime-test 8b6450d link /test pull-controller-runtime-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
@k8s-ci-robot
Merge pull request #735 from droot/bugfix/avoid-duplicate-import
22344ac 
:bugfix: avoid duplicate import/add-to-scheme code snippets
@DirectXMan12 DirectXMan12 self-assigned this Feb 5, 2020
@vincepri vincepri added this to the v0.5.x milestone Feb 21, 2020
@DirectXMan12 DirectXMan12 changed the title 🏃 use new github action syntax 🧀 use new github action syntax Feb 26, 2020
@DirectXMan12 DirectXMan12 changed the title 🧀 use new github action syntax 🏃 use new github action syntax Feb 26, 2020
@alexeldeib
Copy link
Contributor Author

This is stale and doesn't produce the desired behavior anyway, going to close. I think we probably just want to run this script in prow and exit 1 if failed, or else fail the action directly rather than post back to the checks API.

@alexeldeib alexeldeib closed this Apr 7, 2020
@DirectXMan12
Copy link
Contributor

I played around a bit and got it almost working, but got side-tracked :-/

The problem with prow is that it won't recheck on edits to the title, IIRC -- you'd have to manually run "retest". We'd need a plugin or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirectXMan12 DirectXMan12 DirectXMan12 requested changes

@droot droot Awaiting requested review from droot

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@DirectXMan12 DirectXMan12

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.5.x
Development

Successfully merging this pull request may close these issues.

move off of github actions HCL syntax
4 participants
@alexeldeib @k8s-ci-robot @DirectXMan12 @vincepri