validate cert #74
Merged
validate cert #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
size/L
|
cc: @anfernee |
k8s-ci-robot
added
the
cncf-cla: yes
| // Recreate the cert if it's invalid. | ||
| if !validCert(certs) { | ||
| valid, err := validCert(certs, dnsName, 6*month) |
There was a problem hiding this comment.
Maybe move 6*month to a constant.
| // e.g. | ||
| // c, err := tls.X509KeyPair(cert, key) | ||
| // err := c.Verify(options) | ||
| func validCert(certs *generator.Artifacts, dnsName string, validTime time.Duration) (bool, error) { |
There was a problem hiding this comment.
All the return statements returns error as nil. I think you can remove this argument from the return list. Then validCert returns only a bool
mengqiy
commented
Jul 11, 2018
| // e.g. | ||
| // c, err := tls.X509KeyPair(cert, key) | ||
| // err := c.Verify(options) | ||
| func validCert(certs *generator.Artifacts, dnsName string, validTime time.Duration) (bool, error) { |
There was a problem hiding this comment.
The linter is complaining about parameter validTime not being changed :/
It is handy to have this parameter for testing purpose.
|
PTAL |
droot
reviewed
Jul 12, 2018
| @@ -39,6 +42,8 @@ const ( | |||
| ServerCertName = "cert.pem" | |||
| ) | |||
|
|
|||
| const sixMonths = 6 * 31 * 24 * time.Hour | |||
There was a problem hiding this comment.
does it have to be pkg level const ? I see it only being used inside a fn.
anfernee
reviewed
Jul 12, 2018
| ops := x509.VerifyOptions{ | ||
| DNSName: dnsName, | ||
| Roots: pool, | ||
| CurrentTime: time.Now().Add(sixMonths), |
There was a problem hiding this comment.
why 6 months? also it's more like time.Now().AddDate(0, 1, 0) doc
|
PTAL |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Liujingfang1
added
the
approved
justinsb
pushed a commit
to justinsb/controller-runtime
that referenced
this pull request
Dec 7, 2018
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
fixed infinite loop in watchControllerOf API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.