Skip to content

✨ Parameterize webhook key/cert name #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 22, 2020
Merged

✨ Parameterize webhook key/cert name #760

merged 3 commits into from
Jan 22, 2020

Conversation

qinqon
Copy link
Contributor

@qinqon qinqon commented Jan 16, 2020

A user may want to use different names for server key/cert, for
example, if it's using the client-go cert manager util, the
certificate is just a unify pem file with both on it.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 16, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @qinqon. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 16, 2020
@qinqon
Copy link
Contributor Author

qinqon commented Jan 16, 2020

I have the CA signed for [email protected]

@fejta-bot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 16, 2020
@qinqon
Copy link
Contributor Author

qinqon commented Jan 16, 2020

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 16, 2020
@alenkacz
Copy link
Contributor

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@alenkacz: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alenkacz
alenkacz approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm minus the nit :)

@qinqon
Parameterize webhook key/cert name
da4df14 
A user may want to use different names for server key/cert, for
example, if it's using the client-go cert manager util, the
certificate is just a unify pem file with both on it.

Signed-off-by: Quique Llorente <[email protected]>
@qinqon qinqon force-pushed the parameterize-webhook-key-cert-name-2 branch from 7f06b58 to da4df14 Compare January 17, 2020 11:04
@qinqon
Copy link
Contributor Author

qinqon commented Jan 17, 2020

@alenkacz Fixed the nits, can we re-run the tests ?

Adirio
Adirio reviewed Jan 21, 2020
View reviewed changes
Copy link
Contributor

@Adirio Adirio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few NITs, LGTM otherwise.

@alexeldeib
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 21, 2020
qinqon and others added 2 commits January 21, 2020 10:36
@qinqon
Copy link
Contributor Author

qinqon commented Jan 21, 2020

/cc @alexeldeib

Changed the stuff from @Adirio

@alexeldeib
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2020
@alexeldeib
Copy link
Contributor

/assign @DirectXMan12 @gerred

@DirectXMan12 DirectXMan12 changed the title Parameterize webhook key/cert name :sparkles ✨ Parameterize webhook key/cert name Jan 22, 2020
@DirectXMan12
Copy link
Contributor

/approve

as per reviewers' LGTMs

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit b919853 into kubernetes-sigs:master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alenkacz alenkacz alenkacz approved these changes

@Adirio Adirio Adirio approved these changes

@AmitKumarDas AmitKumarDas AmitKumarDas approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@pwittrock pwittrock Awaiting requested review from pwittrock

@alexeldeib alexeldeib Awaiting requested review from alexeldeib

Assignees

@DirectXMan12 DirectXMan12

@gerred gerred

@alexeldeib alexeldeib

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@qinqon @k8s-ci-robot @fejta-bot @alenkacz @alexeldeib @DirectXMan12 @Adirio @AmitKumarDas @gerred