Skip to content

Add 'alenkacz' as reviewer #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2020
Merged

Add 'alenkacz' as reviewer #761

merged 1 commit into from
Jan 23, 2020

Conversation

alenkacz
Copy link
Contributor

I did couple of reviews already and I am working on #563

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 17, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @alenkacz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 17, 2020
@alenkacz
Copy link
Contributor Author

/assign @DirectXMan12

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 17, 2020
@gerred
Copy link
Contributor

gerred commented Jan 21, 2020

/lgtm

let's get her on this train!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2020
@alenkacz
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@alenkacz: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alenkacz
Copy link
Contributor Author

@gerred can you re-run tests please?

@alenkacz
Copy link
Contributor Author

btw. I hunted down a cause of the flake here in the PR, I'll submit a PR with fix

@gerred
Copy link
Contributor

gerred commented Jan 22, 2020

/ok-to-test
/retest

@alenkacz 💥

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 22, 2020
@DirectXMan12
Copy link
Contributor

/lgtm
/approve

welcome aboard 🚢

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alenkacz, DirectXMan12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2020
@DirectXMan12
Copy link
Contributor

@alenkacz are you a k8s org member? if not, happy to sponsor :-)

@gerred
Copy link
Contributor

gerred commented Jan 22, 2020 •
edited
Loading

she's a member of kubernetes, but not kubernetes-sigs it looks like. echoing @DirectXMan12 open that issue to community and I'll throw my 👍 sponsorship in immediately too :)

@kensipe
Copy link

kensipe commented Jan 23, 2020

woot! +1 vote for @alenkacz
Looks like I should join this train!

@alenkacz
Copy link
Contributor Author

hmm I am member of kubernetes org 🤔 https://github.com/orgs/kubernetes/people?utf8=%E2%9C%93&query=alenkacz what else is missing?

Looks like I need to explicitly request it? kubernetes/org#1589 ... we'll see :) I think sponsors are not needed since I am already k8s member but added you guys in case. Thanks

@alenkacz
Copy link
Contributor Author

okay, I am in kubernetes-sigs - could someone please run this command? ->

/verify-owners

@nikhita
Copy link
Member

nikhita commented Jan 23, 2020

That's weird...

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 23, 2020
@nikhita
Copy link
Member

nikhita commented Jan 23, 2020

It worked! 🎉

Computers are hard. 😄

@k8s-ci-robot k8s-ci-robot merged commit c14d8e6 into kubernetes-sigs:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot Awaiting requested review from droot

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees

@DirectXMan12 DirectXMan12

@gerred gerred

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alenkacz @k8s-ci-robot @gerred @DirectXMan12 @kensipe @nikhita