return an additional bool in EnsureCerts #79
Conversation
k8s-ci-robot
added
the
size/L
|
cc @anfernee |
k8s-ci-robot
added
the
cncf-cla: yes
| @@ -45,7 +45,7 @@ const ( | |||
| // CertWriter provides method to handle webhooks. | |||
| type CertWriter interface { | |||
| // EnsureCert ensures that the webhooks have proper certificates. | |||
| EnsureCerts(runtime.Object) error | |||
| EnsureCerts(runtime.Object) (bool, error) | |||
There was a problem hiding this comment.
Maybe add some comments here for the return values
| } | ||
|
|
||
| func createIfNotExists(webhookName string, ch certReadWriter) (*generator.Artifacts, error) { | ||
| func createIfNotExists(webhookName string, ch certReadWriter) (*generator.Artifacts, bool, error) { |
There was a problem hiding this comment.
What does this bool indicate? Seems to be inconsistent with changed.
| if err != nil { | ||
| return certs, err | ||
| } | ||
| return certs, true, err |
There was a problem hiding this comment.
Should this be return certs, false, err?
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mengqiy If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
build: wrap binaries in bin/ directories
No description provided.