Skip to content

Add vincepri to maintainers #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2020
Merged

Add vincepri to maintainers #791

merged 1 commit into from
Feb 19, 2020

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented Feb 5, 2020

Signed-off-by: Vince Prignano [email protected]

To help with grooming and releases.

Related to kubernetes/org#1619

/assign @DirectXMan12

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2020
@vincepri
Copy link
Member Author

/retest

@ncdc
Copy link
Contributor

ncdc commented Feb 18, 2020

+1, we're thrilled to be able to help out here!

@gerred
Copy link
Contributor

gerred commented Feb 18, 2020

/lgtm

@DirectXMan12 had me move myself to approvers from admin, so I'd lean on them to chime in here before approving.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2020
@vincepri
Copy link
Member Author

Thanks @gerred ! We chatted about admin to manage the milestones, do backlog grooming, and perform releases.

@DirectXMan12
Copy link
Contributor

@gerred see my response in kubernetes/org#1619 (comment)

TL;DR: I'd like to have better non-admin roles, but we need something for running the public grooming session this week.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2020
@vincepri
Add vincepri to maintainers
56a400d 
Signed-off-by: Vince Prignano <[email protected]>
@DirectXMan12
Copy link
Contributor

/lgtm

one the caveat that we may shuffle things around a bit later

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2020
@vincepri vincepri changed the title Add vincepri to admins Add vincepri to maintainers Feb 19, 2020
@DirectXMan12
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit 19e72eb into kubernetes-sigs:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@DirectXMan12 DirectXMan12

@gerred gerred

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vincepri @ncdc @gerred @DirectXMan12 @k8s-ci-robot