fix controllerutil_test #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
mengqiy
added
the
do-not-merge/hold
droot
approved these changes
Jul 17, 2018
droot
added
approved
mengqiy
force-pushed
the
fix_controllerutil_test
branch
from
f82486f to
5a961ac
Compare
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
added
size/S
mengqiy
removed
the
do-not-merge/hold
|
Pushed additional minor change. Reapply labels per #80 (review) |
mengqiy
added
the
lgtm
justinsb
pushed a commit
to justinsb/controller-runtime
that referenced
this pull request
Dec 7, 2018
…_test fix controllerutil_test
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
disable debugging in GoReleaser command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test package name should be consist with https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/controller/controllerutil/controllerutil_suite_test.go#L1
Otherwise, causing issue when building with bazel.