Avoid adding test flags when using the null logger #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
LGTM |
DirectXMan12
force-pushed
the
bug/accidentally-testing
branch
from
d5c3ebb to
455d0ad
Compare
|
This should fix the lint issues. I always forget to run gometalinter, since it's not written anywhere (that I've seen). Maybe we should add it to CONTRIBUTING.md or have a makefile target for it, or something? |
|
Yeah, we can add a section in Linter is still complaining. |
|
whoops, typo. Yeah, I found test.sh (it does run all the tests though, and sometimes you just want to run the linter). |
|
I'll push a PR later today around that. |
The null logger from logr is in the same package as the testing logger, which means it accidentally adds testing flags to all binaries that import it. Copy the null logger into the pkg/runtime/log package to avoid this.
DirectXMan12
force-pushed
the
bug/accidentally-testing
branch
from
455d0ad to
434aee9
Compare
|
there, that should fix it. actually remembered to run the right linter command this time ;-) |
k8s-ci-robot
added
the
lgtm
mengqiy
added
the
approved
justinsb
pushed a commit
to justinsb/controller-runtime
that referenced
this pull request
Dec 7, 2018
…lly-testing Avoid adding test flags when using the null logger
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
fixed build artifact path for gsutil copy command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The null logger from logr is in the same package as the testing logger,
which means it accidentally adds testing flags to all binaries that
import it. Copy the null logger into the pkg/runtime/log package
to avoid this.