🏃 Add verification tools, linter and modules #821
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
vincepri
force-pushed
the
add-verifications-tools
branch
from
15c683c to
033c594
Compare
|
/assign @DirectXMan12 |
| @@ -1,6 +1,6 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| # Copyright 2019 The Kubernetes Authors. | |||
| # Copyright 2020 The Kubernetes Authors. | |||
There was a problem hiding this comment.
more for my own knowledge, do we usually update copyright year in kubernetes when a file is updated?
There was a problem hiding this comment.
I don't have a good answer, I changed it because it was mostly rewritten
|
It seems The rest LGTM |
|
@hypnoglow seems I have to re-do this again :D |
Signed-off-by: Vince Prignano <[email protected]>
vincepri
force-pushed
the
add-verifications-tools
branch
from
033c594 to
814d2ab
Compare
|
👍 I'll take a look - was out sick for the past few days |
|
/lgtm this actually looks great, love the cleaned up makefile. Should we update some documentation or use the new targets somewhere? 🤔 EDIT: oh I see, the usage is actually in verify.sh |
k8s-ci-robot
added
the
lgtm
Signed-off-by: Vince Prignano [email protected]
This PR cleans up the use of linters, uses Go Modules to build specific version of external tools (golangci-lint), and provides a way to check that go modules are always up to date.