Skip to content

Remove kube-aggregator from Gopkg.toml #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DirectXMan12
Copy link
Contributor

It's not directly used by anything, and the transitive deps should pull
in the proper version if needed.

Partial fix for #89

It's not directly used by anything, and the transitive deps should pull
in the proper version if needed.
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 26, 2018
@DirectXMan12
Copy link
Contributor Author

cc @grantr

@grantr
Copy link
Contributor

grantr commented Jul 26, 2018

👍 works now.

@droot
Copy link
Contributor

droot commented Jul 26, 2018

/lgtm One of the travis tests was failing, retriggered it.

@droot droot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 26, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: DirectXMan12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ec56f11 into kubernetes-sigs:master Jul 26, 2018
@DirectXMan12 DirectXMan12 deleted the infra/fix-bad-gopkg-toml-constraint branch July 27, 2018 18:28
justinsb pushed a commit to justinsb/controller-runtime that referenced this pull request Dec 7, 2018
…-gopkg-toml-constraint

Remove kube-aggregator from Gopkg.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants