Skip to content

🏃 don't use apidiff on dirty commits #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2020
Merged

🏃 don't use apidiff on dirty commits #910

merged 1 commit into from
Apr 22, 2020

Conversation

alexeldeib
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 17, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 17, 2020
@alexeldeib alexeldeib force-pushed the ace/apifix branch 2 times, most recently from 2e4e855 to f96088b Compare April 17, 2020 23:55
@alexeldeib
Copy link
Contributor Author

/assign @joelanford

@vincepri
Copy link
Member

Is this because it's running during make test?

@alexeldeib
Copy link
Contributor Author

Yeah, exactly. I didn’t double check if it was the apidiff binary itself making the tree dirty or something else, but I figure this is fine either way.

@alexeldeib
Copy link
Contributor Author

I thought it might be because of make test, but they're in separate containers on prow so that can't be it. My other two thoughts are either it's because the binary is built under the git path which makes it dirty or it's something due to how prow checks it out (I looked at that code and nothing stood out immediately).

Either way, I figure we can add logging and try to force it through. We can at least ensure it's running against the right commits and figure out why it fails in the future.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 18, 2020
@alexeldeib
Copy link
Contributor Author

/test pull-controller-runtime-apidiff-master

2 similar comments
@alexeldeib
Copy link
Contributor Author

/test pull-controller-runtime-apidiff-master

@alexeldeib
Copy link
Contributor Author

/test pull-controller-runtime-apidiff-master

@alexeldeib alexeldeib force-pushed the ace/apifix branch 2 times, most recently from af49f80 to 7031917 Compare April 18, 2020 17:19
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 18, 2020
@alexeldeib alexeldeib force-pushed the ace/apifix branch 2 times, most recently from 6a27aab to 1b7e789 Compare April 18, 2020 17:22
@alexeldeib
Copy link
Contributor Author

alexeldeib commented Apr 18, 2020 •
edited
Loading

Would've helped to test on the right branch -_- was wondering why prow wasn't retesting for me

The issue was with go.sum. I guess Go changed a crypto library out under us? I left the git status in case this happens again. We can always revisit and clean up this script further.

@alexeldeib
Copy link
Contributor Author

fixes #681

@joelanford
Copy link
Member

@alexeldeib @vincepri FYI, not sure this is related, but I have noticed some cases where go-apidiff will leave the git tree in a dirty state when it is finished. I haven't had the time to dig into why that happens, but if you notice that, let me know and we can dig deeper.

@joelanford
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2020
@vincepri
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2020
vincepri
vincepri approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeldeib, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2189d40 into kubernetes-sigs:master Apr 22, 2020
@joelanford joelanford mentioned this pull request Jun 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@droot droot Awaiting requested review from droot

Assignees

@joelanford joelanford

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexeldeib @vincepri @joelanford @k8s-ci-robot