Skip to content

🏃 Remove unused attributes from controller #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2020
Merged

🏃 Remove unused attributes from controller #940

merged 1 commit into from
Jun 12, 2020

Conversation

alvaroaleman
Copy link
Member

This removes a set of unused attributes from the controller.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 9, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 9, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2020
@alvaroaleman
Copy link
Member Author

/assign @vincepri

@vincepri
Copy link
Member

@DirectXMan12 Any reason why these fields were included in the first place?

@DirectXMan12
Copy link
Contributor

IIRC, it has to do with injection into the reconciler -- at least Scheme was commonly injected as opposed to directly being passed in, at least in the early days. We'll prob want to figure something out before 1.0.0 wrt that.

Right now, we prob don't want to remove those without double-checking that the corresponding injection still works

@alvaroaleman
Copy link
Member Author

@DirectXMan12 they do work, otherwise this PR wouldn't compile as the corresponding attributes are gone.

The injection is done by just storing the SetFields from the manager and re-using it: https://github.com/kubernetes-sigs/controller-runtime/pull/940/files#diff-3c862eb54a8e0e161b534e0c67e5379eL113

vincepri
vincepri approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vincepri vincepri added this to the v0.6.x milestone Jun 11, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2020
@DirectXMan12
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, DirectXMan12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5362611 into kubernetes-sigs:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@mengqiy mengqiy Awaiting requested review from mengqiy

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6.x
Development

Successfully merging this pull request may close these issues.
4 participants
@alvaroaleman @vincepri @DirectXMan12 @k8s-ci-robot