📖 Prevent errors to be logged multiple times in builtins example

[ialidzhikov]

Reconciler errors are logged by the framework. See

controller-runtime/pkg/internal/controller/controller.go

Line 258 in 198197f

log.Error(err, "Reconciler error", "controller", c.Name, "request", req)

Currently in the builtins example errors are logged 2 times - once by example-controller.reconciler logger and once by the controller-runtime.controller logger. Logging the error in the reconcileReplicaSet itself is superfluous and the controller-runtime idiomatic way would be to return the error and have it logged only once by the controller-runtime.controller logger.

[k8s-ci-robot]

Hi @ialidzhikov. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ialidzhikov]

/assign @mengqiy

[alvaroaleman]

/lgtm
/assign @vincepri

[vincepri]

/ok-to-test

[vincepri]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment