🐛 Avoid marshalling error in debug log line #989

databus23 · 2020-06-10T15:04:33Z

Currently every webhook requests ended up logging this in debug:

2020-06-10T16:04:20.883+0200	DEBUG	controller-runtime.webhook.webhooks	wrote response	{"webhook": "/validate-some-resource", "UID": "e5d00608-7f47-4d00-bd91-b1a8955dc5a7", "allowed": true, "result": {}, "resultError": "got runtime.Object without object metadata: &Status{ListMeta:ListMeta{SelfLink:,ResourceVersion:,Continue:,RemainingItemCount:nil,},Status:,Message:,Reason:,Details:nil,Code:200,}"}

The problem is that a Status Object is a runtime.Object with no metadata which is not well received by the zap.KubeAwareEncoder.

k8s-ci-robot · 2020-06-10T15:04:41Z

Hi @databus23. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vincepri · 2020-08-03T14:50:36Z

/ok-to-test

vincepri · 2020-08-03T14:50:43Z

/assign @alvaroaleman
/approve

alvaroaleman · 2020-08-03T16:14:20Z

pkg/webhook/admission/http.go

@@ -99,6 +99,6 @@ func (wh *Webhook) writeResponse(w io.Writer, response Response) {
 		wh.writeResponse(w, Errored(http.StatusInternalServerError, err))
 	} else {
 		res := responseAdmissionReview.Response
-		wh.log.V(1).Info("wrote response", "UID", res.UID, "allowed", res.Allowed, "result", res.Result)
+		wh.log.V(1).Info("wrote response", "UID", res.UID, "allowed", res.Allowed, "code", res.Result.Code, "reason", res.Result.Reason)


res.Result might be nil if the request gets approved, if we just unconditionally access it like this we might panic

Ups. Good catch!

Currently every webhook requests ended up logging this in debug: ``` 2020-06-10T16:04:20.883+0200 DEBUG controller-runtime.webhook.webhooks wrote response {"webhook": "/validate-some-resource", "UID": "e5d00608-7f47-4d00-bd91-b1a8955dc5a7", "allowed": true, "result": {}, "resultError": "got runtime.Object without object metadata: &Status{ListMeta:ListMeta{SelfLink:,ResourceVersion:,Continue:,RemainingItemCount:nil,},Status:,Message:,Reason:,Details:nil,Code:200,}"} ``` The problem is that a `Status` Object is a runtime.Object but which has no metadata which is not well received the `KubeAwareEncoder`. Signed-off-by: Fabian Ruff <[email protected]>

databus23 · 2020-08-04T09:08:32Z

/retest

databus23 · 2020-08-04T09:16:48Z

@vincepri I addressed the nil pointer access. Not sure about the failing tests now. I think its unrelated timeouts happening somewhere else.

databus23 · 2020-08-04T11:05:20Z

/test pull-controller-runtime-test-master

alvaroaleman

/lgtm
Thanks!

vincepri

/approve

k8s-ci-robot · 2020-08-04T13:48:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: databus23, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vincepri · 2020-08-04T13:48:37Z

/hold cancel
/milestone v0.6.x

vincepri · 2020-08-04T14:00:13Z

/retest

vassilvk · 2020-08-27T21:31:57Z

@databus23, did this fix make it into 0.6.2?
I upgraded from 0.5.0 to 0.6.2, but I'm still getting the got runtime.Object without object metadata error.

vassilvk · 2020-08-27T21:40:47Z

@databus23 - actually - never mind :)
I was looking at the wrong binary.
It works as expected with 0.6.2 - thank you!!!

vincepri · 2020-08-27T21:46:20Z

Needs a new release, probably going to do one tomorrow if time permits

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 10, 2020

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 10, 2020

k8s-ci-robot requested review from DirectXMan12 and joelanford June 10, 2020 15:04

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 10, 2020

databus23 changed the title ~~Avoid marshalling error in debug log line~~ 🐛 Avoid marshalling error in debug log line Jun 10, 2020

databus23 changed the title ~~🐛 Avoid marshalling error in debug log line~~ 🐛 Avoid marshalling error in debug log line Jun 10, 2020

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 3, 2020

k8s-ci-robot assigned alvaroaleman Aug 3, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2020

alvaroaleman reviewed Aug 3, 2020

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2020

databus23 force-pushed the patch-2 branch 3 times, most recently from 0bd08ae to 21139a3 Compare August 4, 2020 08:59

databus23 force-pushed the patch-2 branch from 21139a3 to 79de63c Compare August 4, 2020 08:59

alvaroaleman approved these changes Aug 4, 2020

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2020

vincepri approved these changes Aug 4, 2020

View reviewed changes

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2020

k8s-ci-robot added this to the v0.6.x milestone Aug 4, 2020

k8s-ci-robot merged commit 1abbd13 into kubernetes-sigs:master Aug 4, 2020

🐛 Avoid marshalling error in debug log line #989

🐛 Avoid marshalling error in debug log line #989

Uh oh!

Conversation

databus23 commented Jun 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Jun 10, 2020

Uh oh!

vincepri commented Aug 3, 2020

Uh oh!

vincepri commented Aug 3, 2020

Uh oh!

alvaroaleman Aug 3, 2020

Choose a reason for hiding this comment

Uh oh!

vincepri Aug 3, 2020

Choose a reason for hiding this comment

Uh oh!

databus23 Aug 4, 2020

Choose a reason for hiding this comment

Uh oh!

databus23 commented Aug 4, 2020

Uh oh!

databus23 commented Aug 4, 2020

Uh oh!

databus23 commented Aug 4, 2020

Uh oh!

alvaroaleman left a comment

Choose a reason for hiding this comment

Uh oh!

vincepri left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Aug 4, 2020

Uh oh!

vincepri commented Aug 4, 2020

Uh oh!

vincepri commented Aug 4, 2020

Uh oh!

vassilvk commented Aug 27, 2020

Uh oh!

vassilvk commented Aug 27, 2020

Uh oh!

vincepri commented Aug 27, 2020

Uh oh!

Uh oh!

databus23 commented Jun 10, 2020 •

edited

Loading